Malicious site protection feature flags #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-feature-flags
branch
3 times, most recently
from
899ad16 to
f156fd5
Compare
alessandroboron
commented
Dec 11, 2024
| sut = MaliciousSiteProtectionFeatureFlags(featureFlagger: featureFlaggerMock, privacyConfigManager: configurationManagerMock) | ||
| } | ||
|
|
||
| deinit { |
There was a problem hiding this comment.
now that I think of nilling properties in deinit is probably not needed as it will do it automatically. I will fix it.
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-address-bar-and-privacy-dashboard
branch
from
95a56b5 to
014ea13
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-feature-flags
branch
from
a41d843 to
99e6543
Compare
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions. |
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-address-bar-and-privacy-dashboard
branch
from
014ea13 to
b4d4dd0
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-feature-flags
branch
from
99e6543 to
a76c78f
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-feature-flags
branch
from
a76c78f to
560ef30
Compare
alessandroboron
commented
Jan 10, 2025
| @@ -146,6 +150,8 @@ extension FeatureFlag: FeatureFlagDescribing { | |||
| return .remoteReleasable(.subfeature(PrivacyProSubfeature.isLaunchedROWOverride)) | |||
| case .freeTrials: | |||
| return .remoteDevelopment(.subfeature(PrivacyProSubfeature.freeTrials)) | |||
| case .maliciousSiteProtection: | |||
| return .remoteDevelopment(.subfeature(MaliciousSiteProtectionSubfeature.onByDefault)) | |||
There was a problem hiding this comment.
Subfeature required to enable remote rollout at a later stage.
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-feature-flags
branch
from
7d3a83b to
744d6aa
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-address-bar-and-privacy-dashboard
branch
from
bfe728f to
5e0082f
Compare
Base automatically changed from
alessandro/malicious-site-protection-address-bar-and-privacy-dashboard
to
alessandro/malicious-site-protection
January 14, 2025 03:25
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-feature-flags
branch
from
744d6aa to
e791a06
Compare
alessandroboron
merged commit 3af5452
into
alessandro/malicious-site-protection
13 checks passed
alessandroboron
deleted the
alessandro/malicious-site-protection-feature-flags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207944134334659/f
Tech Design URL: https://app.asana.com/0/1206329551987282/1207273224076495/f
CC: @not-a-rootkit
Description:
Add Feature flag class as per tech design to check if malicious site protection feature is enabled and should check protection for domain based on the domain privacy preferences.
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template